From: Stijn Tintel <stijn@linux-ipv6.be>
Date: Thu, 6 Jan 2022 11:12:37 +0000 (+0200)
Subject: fw4.uc: filter duplicates in fw4.set
X-Git-Url: http://git.openwrt.org/%22https:/collectd.org//%22/%22https:/collectd.org/%22?a=commitdiff_plain;h=9ebc2f4f10ab14a6f3b6df3069ce3410a4af66bc;p=project%2Ffirewall4.git

fw4.uc: filter duplicates in fw4.set

Suggested-by: Jo-Philipp Wich <jo@mein.io>
Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
Reviewed-by: Jo-Philipp Wich <jo@mein.io>
---

diff --git a/root/usr/share/ucode/fw4.uc b/root/usr/share/ucode/fw4.uc
index c07b355..7472509 100644
--- a/root/usr/share/ucode/fw4.uc
+++ b/root/usr/share/ucode/fw4.uc
@@ -1405,7 +1405,9 @@ return {
 	},
 
 	set: function(v, force) {
-		v = to_array(v);
+		let seen = {};
+
+		v = filter(to_array(v), item => !seen[item]++);
 
 		if (force || length(v) != 1)
 			return sprintf('{ %s }', join(', ', map(v, this.quote)));